GYRO-378: ELBV2 Authenticate Cognito Action, primary key will show null if referenced User Pool Client and User Pool Domain not created. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if userPoolArn is null and if so output blank. If userpool client's id is null use the name.
| @@ -130,7 +130,10 @@ public void setUserPoolDomain(UserPoolDomainResource userPoolDomain) { | |||
| } | |||
|
|
|||
| public String primaryKey() { | |||
| return String.format("%s/%s/%s", getUserPoolArn(), getUserPoolClient().getId(), getUserPoolDomain().getDomain()); | |||
| return String.format("%s %s %s", | |||
| getUserPoolArn() != null ? getUserPoolArn() : "", | |||
There was a problem hiding this comment.
This is going to leave an extra space in the output.
Create authenticate-cognito-action domainexample
| @@ -130,7 +130,10 @@ public void setUserPoolDomain(UserPoolDomainResource userPoolDomain) { | |||
| } | |||
|
|
|||
| public String primaryKey() { | |||
| return String.format("%s/%s/%s", getUserPoolArn(), getUserPoolClient().getId(), getUserPoolDomain().getDomain()); | |||
| return String.format("%s%s %s", | |||
There was a problem hiding this comment.
Can you make this a StringBuilder that only appends when necessary.
…imary key generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.